Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update compatibility to
jupyterlab>=4.1
, and update dependencies accordingly, the keyboard shortcuts are not compatible starting from version 4.1.0.Checklist
doit lint
locallyReferences
Related to #63
Code changes
When the notebook changes to full windowed mode (the default since lab 4.1) some CSS rules are applied to the viewport node, and are not properly removed when switching back to 'no windowing' mode. These rules should be fixed upstream in Jupyterlab, but are also fixed here for backward compatibility.
.jp-WindowedPanel-inner
has been fixed in lab 2.2 with Fix width and margins of the notebook footer. jupyterlab/jupyterlab#16383.jp-WindowedPanel-viewport
should be fixed with Restore viewportmin-height
when not windowing jupyterlab/jupyterlab#16979 (comment).jp-ThemedContainer
User-facing changes
None
Backwards-incompatible changes
None